JS updates to attachment type #1325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isahers1
changed the title
jacoblee93
reviewed
Dec 11, 2024
| }), | ||
| }); | ||
| // eslint-disable-next-line no-instanceof/no-instanceof | ||
| if (content instanceof Blob) { |
There was a problem hiding this comment.
Wait sorry why do we need this vs. just accepting UInt8Array again?
I think the content typing doesn't include Blob here?
I know I said earlier we shouldn't do this - but I wonder if there's a way we can accept a Node Buffer here. Will talk to you in a sec.
There was a problem hiding this comment.
Also - can this piggyback off the new method you created below?
There was a problem hiding this comment.
because attachment could be a Blob now (from you: https://langchain.slack.com/archives/D076HL2E77B/p1733946087301879)
jacoblee93
reviewed
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.